Skip to content

Shipping Labels: Always show all contents of UPS TOS modal #15926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 22, 2025
Merged

Shipping Labels: Always show all contents of UPS TOS modal #15926

merged 4 commits into from
Jul 22, 2025

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jul 18, 2025

Closes WOOMOB-874

Description

This PR updates to UPS TOS modal to always be full length to avoid clipping off content in different font sizes and device sizes.

Testing steps

  1. Build and run the app on an iPad (or simulator)
  2. Log in to a test store with Woo Shipping set up.
  3. Navigate to the Orders tab and select an order eligible for label purchase.
  4. Select Create shipping label > update the origin address to one that hasn't accepted TOS for UPS.
  5. Proceed to purchase a label.
  6. Confirm that the UPS TOS modal shows up in full length.

Testing information

Tested and confirmed with simulator iPhone 16 and iPad A16.

Screenshots

Before After
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 22.9 milestone Jul 18, 2025
@itsmeichigo itsmeichigo added feature: shipping labels Related to creating, ordering, or printing shipping labels. Accessibility labels Jul 18, 2025
@itsmeichigo itsmeichigo marked this pull request as ready for review July 18, 2025 06:42
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 18, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15926-3ec6679
Version22.8
Bundle IDcom.automattic.alpha.woocommerce
Commit3ec6679
Installation URL771r1o69vtas0
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo
Merge branch 'woomob-870-shipping-labels-validate-dimensions-for-cust…
d638298 
…om-packages' into woomob-874-shipping-labels-third-checkbox-on-ups-popup-is-not-visible
Base automatically changed from woomob-870-shipping-labels-validate-dimensions-for-custom-packages to trunk July 22, 2025 03:45
@itsmeichigo itsmeichigo enabled auto-merge July 22, 2025 03:50
@itsmeichigo itsmeichigo merged commit c1cce56 into trunk Jul 22, 2025
13 checks passed
@itsmeichigo itsmeichigo deleted the woomob-874-shipping-labels-third-checkbox-on-ups-popup-is-not-visible branch July 22, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelKayumov RafaelKayumov RafaelKayumov approved these changes

Assignees

No one assigned

Labels

Accessibility feature: shipping labels Related to creating, ordering, or printing shipping labels.

Projects

None yet

Milestone

22.9

Development

Successfully merging this pull request may close these issues.

4 participants

@itsmeichigo @wpmobilebot @RafaelKayumov